I think for a "special situation" they may serve a purpose. For EDC, I say nope....
It's interesting the guy in the videos always slowly reaches in, gets a good purchase, then pulls out the gun. I don't think it would be that smooth if you're fighting for your life- without time to put your hand on the gun first...
They're a gimmick. But potentially more useful than most other CCW gimmicks ( looking at you thunderwear, etc ) .
Better than holsters claim requires a large chunk of salt . BUT pocket carry is already fairly common using "normal v pants and small guns . These pants would certainly seem to be an improvement over regular pants for pocket carry .