Depends - factory-plated or not?
If you're a collector you'd avoid replated because they aren't original, but they have their own niche (esp WW2 bring-backs).
Some were done better than others and last accordingly.
If it's an old gun and the nickel still looks good, it will probably last and still look good when you're gone.
You just have to be REALLY careful about how and what you use to clean it, as Hoppe's etc can get under the nickel and lift it.
I have a 100 yo factory-plated Colt M1908 that looks factory fresh.
Any cleaning solution with ammonia as an ingredient can get under any breaks in the plating and cause separation but the copper or base metal below it. Essentially...the nickel plating can start to peel off.
Avoid ammonia based cleaners and there should be no problems.